Test/fix symlink test/extract in v1 file format

Previous implementation sent too many bytes to decompressor if size was
less than 1024.

src/main.c

@@ -67,13 +67,12 @@ int main(int argc, const char **argv) {
     }
   }
 
-  SDArchiverParsedStatus parsed_status;
   __attribute__((cleanup(simple_archiver_list_free)))
   SDArchiverLinkedList *filenames =
-      simple_archiver_parsed_to_filenames(&parsed, &parsed_status);
+      simple_archiver_parsed_to_filenames(&parsed);
-  if (!filenames || parsed_status != SDAPS_SUCCESS) {
+  if (!filenames) {
-    fprintf(stderr, "ERROR: %s!\n",
+    fprintf(stderr,
-            simple_archiver_parsed_status_to_str(parsed_status));
+            "ERROR: Failed to resolve filenames from positional arguments!\n");
     return 8;
   }
 

src/parser.c

@@ -131,17 +131,6 @@ int list_remove_same_str_fn(void *data, void *ud) {
   return 0;
 }
 
-char *simple_archiver_parsed_status_to_str(SDArchiverParsedStatus status) {
-  switch (status) {
-    case SDAPS_SUCCESS:
-      return "Success";
-    case SDAPS_NO_USER_CWD:
-      return "No user current working directory (-C <dir>)";
-    default:
-      return "Unknown error";
-  }
-}
-
 void simple_archiver_print_usage(void) {
   fprintf(stderr, "Usage flags:\n");
   fprintf(stderr, "-c : create archive file\n");
@@ -378,7 +367,7 @@ void simple_archiver_free_parsed(SDArchiverParsed *parsed) {
 }
 
 SDArchiverLinkedList *simple_archiver_parsed_to_filenames(
-    const SDArchiverParsed *parsed, SDArchiverParsedStatus *status_out) {
+    const SDArchiverParsed *parsed) {
   SDArchiverLinkedList *files_list = simple_archiver_list_init();
   __attribute__((cleanup(simple_archiver_hash_map_free)))
   SDArchiverHashMap *hash_map = simple_archiver_hash_map_init();
@@ -392,9 +381,6 @@ SDArchiverLinkedList *simple_archiver_parsed_to_filenames(
     original_cwd = realpath(".", NULL);
     if (chdir(parsed->user_cwd)) {
       simple_archiver_list_free(&files_list);
-      if (status_out) {
-        *status_out = SDAPS_NO_USER_CWD;
-      }
       return NULL;
     }
   }
@@ -621,8 +607,5 @@ SDArchiverLinkedList *simple_archiver_parsed_to_filenames(
     }
   }
 
-  if (status_out) {
-    *status_out = SDAPS_SUCCESS;
-  }
   return files_list;
 }

src/parser.h

@@ -59,14 +59,6 @@ typedef struct SDArchiverFileInfo {
   char *link_dest;
 } SDArchiverFileInfo;
 
-typedef enum SDArchiverParsedStatus {
-  SDAPS_SUCCESS,
-  SDAPS_NO_USER_CWD,
-} SDArchiverParsedStatus;
-
-/// Returned c-string does not need to be free'd.
-char *simple_archiver_parsed_status_to_str(SDArchiverParsedStatus status);
-
 void simple_archiver_print_usage(void);
 
 SDArchiverParsed simple_archiver_create_parsed(void);
@@ -82,6 +74,6 @@ void simple_archiver_free_parsed(SDArchiverParsed *parsed);
 
 /// Each entry in the linked list is an SDArchiverFileInfo object.
 SDArchiverLinkedList *simple_archiver_parsed_to_filenames(
-    const SDArchiverParsed *parsed, SDArchiverParsedStatus *status_out);
+    const SDArchiverParsed *parsed);
 
 #endif