From 6ead1e1d3d89aad7bf17300e7d49a5250e7b45af Mon Sep 17 00:00:00 2001 From: Stephen Seo Date: Tue, 25 Sep 2018 15:16:35 +0900 Subject: [PATCH] Fix falling perpetually with Freeze mode, fixes --- .../TurnBasedMinecraft/client/BattleMusic.java | 4 ++-- .../seodisparate/TurnBasedMinecraft/common/Battle.java | 8 ++------ .../seodisparate/TurnBasedMinecraft/common/Combatant.java | 2 +- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/seodisparate/TurnBasedMinecraft/client/BattleMusic.java b/src/main/java/com/seodisparate/TurnBasedMinecraft/client/BattleMusic.java index 47f1324..b448dfb 100644 --- a/src/main/java/com/seodisparate/TurnBasedMinecraft/client/BattleMusic.java +++ b/src/main/java/com/seodisparate/TurnBasedMinecraft/client/BattleMusic.java @@ -148,7 +148,7 @@ public class BattleMusic public void playBattle(float volume) { - if(!initialized || volume <= 0.0f) + if(!initialized || volume <= 0.0f || battleMusic.isEmpty()) { return; } @@ -163,7 +163,7 @@ public class BattleMusic public void playSilly(float volume) { - if(!initialized || volume <= 0.0f) + if(!initialized || volume <= 0.0f || sillyMusic.isEmpty()) { return; } diff --git a/src/main/java/com/seodisparate/TurnBasedMinecraft/common/Battle.java b/src/main/java/com/seodisparate/TurnBasedMinecraft/common/Battle.java index bf1eea5..f69aa1c 100644 --- a/src/main/java/com/seodisparate/TurnBasedMinecraft/common/Battle.java +++ b/src/main/java/com/seodisparate/TurnBasedMinecraft/common/Battle.java @@ -147,7 +147,6 @@ public class Battle if(TurnBasedMinecraftMod.config.isFreezeCombatantsEnabled()) { newCombatant.x = e.posX; - newCombatant.y = e.posY; newCombatant.z = e.posZ; newCombatant.yaw = e.rotationYaw; newCombatant.pitch = e.rotationPitch; @@ -176,7 +175,6 @@ public class Battle if(TurnBasedMinecraftMod.config.isFreezeCombatantsEnabled()) { newCombatant.x = e.posX; - newCombatant.y = e.posY; newCombatant.z = e.posZ; newCombatant.yaw = e.rotationYaw; newCombatant.pitch = e.rotationPitch; @@ -270,7 +268,6 @@ public class Battle if(TurnBasedMinecraftMod.config.isFreezeCombatantsEnabled()) { newCombatant.x = e.posX; - newCombatant.y = e.posY; newCombatant.z = e.posZ; newCombatant.yaw = e.rotationYaw; newCombatant.pitch = e.rotationPitch; @@ -310,7 +307,6 @@ public class Battle if(TurnBasedMinecraftMod.config.isFreezeCombatantsEnabled()) { newCombatant.x = e.posX; - newCombatant.y = e.posY; newCombatant.z = e.posZ; newCombatant.yaw = e.rotationYaw; newCombatant.pitch = e.rotationPitch; @@ -574,11 +570,11 @@ public class Battle { for(Combatant c : sideA.values()) { - c.entity.setPositionAndRotation(c.x, c.y, c.z, c.yaw, c.pitch); + c.entity.setPositionAndRotation(c.x, c.entity.posY, c.z, c.yaw, c.pitch); } for(Combatant c : sideB.values()) { - c.entity.setPositionAndRotation(c.x, c.y, c.z, c.yaw, c.pitch); + c.entity.setPositionAndRotation(c.x, c.entity.posY, c.z, c.yaw, c.pitch); } } diff --git a/src/main/java/com/seodisparate/TurnBasedMinecraft/common/Combatant.java b/src/main/java/com/seodisparate/TurnBasedMinecraft/common/Combatant.java index d2ac975..ab4805a 100644 --- a/src/main/java/com/seodisparate/TurnBasedMinecraft/common/Combatant.java +++ b/src/main/java/com/seodisparate/TurnBasedMinecraft/common/Combatant.java @@ -20,7 +20,7 @@ public class Combatant public int remainingDefenses; public int battleID; public double x; - public double y; + //public double y; // y is ignored to prevent perpetual fall damage when FreezeBattleCombatants is enabled public double z; public float yaw; public float pitch;