From fd40bae73fba5ce5bfb755f7a94c1264684324ac Mon Sep 17 00:00:00 2001 From: Stephen Seo Date: Tue, 19 Dec 2023 13:47:19 +0900 Subject: [PATCH] Tweak compare_exchange_weak(...) in spin-lock --- src/CXX11_shared_spin_lock.cpp | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/CXX11_shared_spin_lock.cpp b/src/CXX11_shared_spin_lock.cpp index ced00dc..0869806 100644 --- a/src/CXX11_shared_spin_lock.cpp +++ b/src/CXX11_shared_spin_lock.cpp @@ -27,7 +27,7 @@ UDPC::LockObj UDPC::SharedSpinLock::spin_read_lock() { bool expected; while (true) { expected = false; - if(spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if(spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (!write) { ++read; spinLock.store(false, std::memory_order_release); @@ -43,7 +43,7 @@ UDPC::LockObj UDPC::SharedSpinLock::try_spin_read_lock() { bool expected; while (true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (!write) { ++read; spinLock.store(false, std::memory_order_release); @@ -62,7 +62,7 @@ void UDPC::SharedSpinLock::read_unlock(UDPC::Badge &&badge) { bool expected; while (true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (read > 0) { --read; badge.isValid = false; @@ -78,7 +78,7 @@ UDPC::LockObj UDPC::SharedSpinLock::spin_write_lock() { bool expected; while (true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (!write && read == 0) { write = true; spinLock.store(false, std::memory_order_release); @@ -94,7 +94,7 @@ UDPC::LockObj UDPC::SharedSpinLock::try_spin_write_lock() { bool expected; while (true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (!write && read == 0) { write = true; spinLock.store(false, std::memory_order_release); @@ -113,7 +113,7 @@ void UDPC::SharedSpinLock::write_unlock(UDPC::Badge &&badge) { bool expected; while(true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (write) { write = false; badge.isValid = false; @@ -130,7 +130,7 @@ UDPC::LockObj UDPC::SharedSpinLock::trade_write_for_read_lock(UDPC::LockO bool expected; while (true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (write && read == 0) { read = 1; write = false; @@ -153,7 +153,7 @@ UDPC::LockObj UDPC::SharedSpinLock::try_trade_write_for_read_lock(UDPC::L bool expected; while (true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (write && read == 0) { read = 1; write = false; @@ -176,7 +176,7 @@ UDPC::LockObj UDPC::SharedSpinLock::trade_read_for_write_lock(UDPC::LockOb bool expected; while (true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (!write && read == 1) { read = 0; write = true; @@ -199,7 +199,7 @@ UDPC::LockObj UDPC::SharedSpinLock::try_trade_read_for_write_lock(UDPC::Lo bool expected; while (true) { expected = false; - if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { + if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) { if (!write && read == 1) { read = 0; write = true;