From: Stephen Seo <seo.disparate@gmail.com>
Date: Sat, 4 Feb 2023 12:32:09 +0000 (+0900)
Subject: Refactor "no-password-fix"
X-Git-Tag: 0.4.6~3^2
X-Git-Url: https://git.seodisparate.com/stephenseo/static/git-logo.png?a=commitdiff_plain;h=aa6fb750e7ac405a5330f04093e69a6c95dc5d94;p=mpd_info_screen

Refactor "no-password-fix"

Refactors the fix for the use case of when MPD requires no password.
---

diff --git a/src/mpd_handler.rs b/src/mpd_handler.rs
index 5064680..80828af 100644
--- a/src/mpd_handler.rs
+++ b/src/mpd_handler.rs
@@ -250,6 +250,8 @@ impl MPDHandler {
         )
         .map_err(|_| String::from("Failed to get TCP connection (is MPD running?)"))?;
 
+        let password_is_empty = password.is_empty();
+
         let s = MPDHandler {
             state: Arc::new(RwLock::new(MPDHandlerState {
                 art_data: Vec::new(),
@@ -263,10 +265,10 @@ impl MPDHandler {
                 current_binary_size: 0,
                 poll_state: PollState::None,
                 stream,
-                password: password.clone(),
+                password,
                 error_text: String::new(),
                 can_authenticate: true,
-                is_authenticated: password.is_empty(),
+                is_authenticated: password_is_empty,
                 can_get_album_art: true,
                 can_get_album_art_in_dir: true,
                 can_get_status: true,