stephenseo/UDPConnection
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages 1 Wiki Activity Actions

Compare commits

base: stephenseo:4d7f60092edbbf952319fe927d3dc54bfd8ec268
Branches Tags
stephenseo:master
stephenseo:dev
stephenseo:conan
stephenseo:1.2
stephenseo:1.1
stephenseo:1.0
..
compare: stephenseo:fd40bae73fba5ce5bfb755f7a94c1264684324ac
Branches Tags
stephenseo:dev
stephenseo:master
stephenseo:conan
stephenseo:1.2
stephenseo:1.1
stephenseo:1.0

6 commits
4d7f60092e ... fd40bae73f

Author SHA1 Message Date
Stephen Seo
fd40bae73f Tweak compare_exchange_weak(...) in spin-lock 2023-12-19 16:46:48 +09:00
Stephen Seo
3e810d27e0 Fix invalid use of mutex in TSLQueue 
Mutex was removed in favor of the custom SharedSpinLock.
 2023-12-19 16:46:48 +09:00
Stephen Seo
a6e22271ff Don't fail on "try" fns if failed to get spinLock 
In SharedSpinLock: Only fail on "try" fns after spinLock was acquired
and condition is not met.
 2023-12-19 16:46:48 +09:00
Stephen Seo
cd96504e34 Refactor shared-spin-lock to use atomic "spinLock" 2023-12-19 16:46:48 +09:00
Stephen Seo
424b3cd127 Minor refactorings 2023-12-19 16:46:48 +09:00
Stephen Seo
980042ad62 Reland C++11 "shared_lock" with iter remove fix 
On iterator remove, the iterator will trade the read lock for a write
lock, and trade back for a read lock once the remove has been completed.
 2023-12-19 16:46:48 +09:00
1 changed files with 10 additions and 10 deletions
Show stats Expand all files Collapse all files

20
src/CXX11_shared_spin_lock.cpp
View file

@ -27,7 +27,7 @@ UDPC::LockObj<false> UDPC::SharedSpinLock::spin_read_lock() {
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if(spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if(spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (!write) { if (!write) {
++read; ++read;
spinLock.store(false, std::memory_order_release); spinLock.store(false, std::memory_order_release);
@ -43,7 +43,7 @@ UDPC::LockObj<false> UDPC::SharedSpinLock::try_spin_read_lock() {
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (!write) { if (!write) {
++read; ++read;
spinLock.store(false, std::memory_order_release); spinLock.store(false, std::memory_order_release);
@ -62,7 +62,7 @@ void UDPC::SharedSpinLock::read_unlock(UDPC::Badge &&badge) {
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (read > 0) { if (read > 0) {
--read; --read;
badge.isValid = false; badge.isValid = false;
@ -78,7 +78,7 @@ UDPC::LockObj<true> UDPC::SharedSpinLock::spin_write_lock() {
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (!write && read == 0) { if (!write && read == 0) {
write = true; write = true;
spinLock.store(false, std::memory_order_release); spinLock.store(false, std::memory_order_release);
@ -94,7 +94,7 @@ UDPC::LockObj<true> UDPC::SharedSpinLock::try_spin_write_lock() {
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (!write && read == 0) { if (!write && read == 0) {
write = true; write = true;
spinLock.store(false, std::memory_order_release); spinLock.store(false, std::memory_order_release);
@ -113,7 +113,7 @@ void UDPC::SharedSpinLock::write_unlock(UDPC::Badge &&badge) {
bool expected; bool expected;
while(true) { while(true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (write) { if (write) {
write = false; write = false;
badge.isValid = false; badge.isValid = false;
@ -130,7 +130,7 @@ UDPC::LockObj<false> UDPC::SharedSpinLock::trade_write_for_read_lock(UDPC::LockO
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (write && read == 0) { if (write && read == 0) {
read = 1; read = 1;
write = false; write = false;
@ -153,7 +153,7 @@ UDPC::LockObj<false> UDPC::SharedSpinLock::try_trade_write_for_read_lock(UDPC::L
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (write && read == 0) { if (write && read == 0) {
read = 1; read = 1;
write = false; write = false;
@ -176,7 +176,7 @@ UDPC::LockObj<true> UDPC::SharedSpinLock::trade_read_for_write_lock(UDPC::LockOb
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (!write && read == 1) { if (!write && read == 1) {
read = 0; read = 0;
write = true; write = true;
@ -199,7 +199,7 @@ UDPC::LockObj<true> UDPC::SharedSpinLock::try_trade_read_for_write_lock(UDPC::Lo
bool expected; bool expected;
while (true) { while (true) {
expected = false; expected = false;
if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire, std::memory_order_relaxed)) { if (spinLock.compare_exchange_weak(expected, true, std::memory_order_acquire)) {
if (!write && read == 1) { if (!write && read == 1) {
read = 0; read = 0;
write = true; write = true;